BLD: 3.6.1 ABI compat #16066
Merged
BLD: 3.6.1 ABI compat #16066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Apr 20, 2017
| @@ -17,8 +17,19 @@ The full license is in the LICENSE file, distributed with this software. | |||
| PySlice_GetIndicesEx changes signature in PY3 | |||
| but 3.6.1 in particular changes the behavior of this function slightly | |||
| https://bugs.python.org/issue27867 | |||
|
|
|||
|
|
|||
| In 3.6.1 PySlice_GetIndicesEx was changed to a macro | |||
There was a problem hiding this comment.
This looks like it does what you're hoping it does to me.
Codecov Report
@@ Coverage Diff @@
## master #16066 +/- ##
==========================================
- Coverage 90.84% 90.82% -0.03%
==========================================
Files 159 159
Lines 50791 50791
==========================================
- Hits 46143 46131 -12
- Misses 4648 4660 +12
Continue to review full report at Codecov.
|
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master --name-only -- '*.py' | flake8 --diffSo I think this works - locally was able to build a wheel with
3.6.1and import it into a3.6.0environment, which was failing before this patch.